Support HTTP Digest authentication via auth-method

[hilbert]

Hi all!

As https://community.openvpn.net/openvpn/w ... n21ManPage states:

auth-method should be one of "none", "basic", or "ntlm".

HTTP Digest authentication is supported as well, but only via the auto or auto-nct flags [...].

The digest algorithm is already implemented and the method is discovered and used when auto is set. The problem is that auto and authfile can't be both used at the same time. Therefore I sugest to apply the following patch on openvpn/proxy.c source file for allowing Digest authentication via auth-method config, and thus we can set credentials via authfile (currently we can't). The Next is the patch I suggest (it was made on openvpn-2.3.10 version):

Code: Select all

diff --unified proxy.c proxy.new.c
--- proxy.c	2015-12-21 07:57:26 -0500
+++ proxy.new.c	2016-03-24 22:51:42 -0500
@@ -457,6 +457,10 @@
 	p->auth_method = HTTP_AUTH_NONE;
       else if (!strcmp (o->auth_method_string, "basic"))
 	p->auth_method = HTTP_AUTH_BASIC;
+#if PROXY_DIGEST_AUTH
+      else if (!strcmp (o->auth_method_string, "digest"))
+	p->auth_method = HTTP_AUTH_DIGEST;
+#endif
 #if NTLM
       else if (!strcmp (o->auth_method_string, "ntlm"))
 	p->auth_method = HTTP_AUTH_NTLM;

I wish some of the development team could review this topic.

Best regards!
Hilbert.

[Traffic]

Please submit to the developer mailing list.